Re: [Xen-devel] [PATCH RFC 1/4] hvmloader/ovmf: increase blob size to 2MB

[Ian Campbell <Ian.Campbell@xxxxxxxxxx>]

On Tue, 2013-11-19 at 20:49 +0000, Wei Liu wrote:
> On Tue, Nov 19, 2013 at 05:49:15PM +0000, Ian Campbell wrote:
> > On Fri, 2013-11-15 at 15:59 +0000, Wei Liu wrote:
> > > The debug build of OVMF now can be as large as 2MB.
> > 
> > And smaller builds are happy to be loaded lower?
> 
> Yes, 1MB build (release build) works too.

OK, thanks for confirming.

Acked-by: Ian Campbell <ian.campbell@xxxxxxxxxx>

Although you may also wish to consider basing the address on
0x100000000ULL-sizeof(ovmf). Perhaps with suitable rounding down.

> 
> > 
> > > 
> > > Signed-off-by: Wei Liu <wei.liu2@xxxxxxxxxx>
> > > ---
> > >  tools/firmware/hvmloader/ovmf.c |    4 ++--
> > >  1 file changed, 2 insertions(+), 2 deletions(-)
> > > 
> > > diff --git a/tools/firmware/hvmloader/ovmf.c 
> > > b/tools/firmware/hvmloader/ovmf.c
> > > index ee4cbbf..5c83626 100644
> > > --- a/tools/firmware/hvmloader/ovmf.c
> > > +++ b/tools/firmware/hvmloader/ovmf.c
> > > @@ -38,8 +38,8 @@
> > >  #define ROM_INCLUDE_OVMF
> > >  #include "roms.inc"
> > >  
> > > -#define OVMF_BEGIN              0xFFF00000ULL
> > > -#define OVMF_SIZE               0x00100000ULL
> > > +#define OVMF_BEGIN              0xFFE00000ULL
> > > +#define OVMF_SIZE               0x00200000ULL
> > >  #define OVMF_MAXOFFSET          0x000FFFFFULL
> > >  #define OVMF_END                (OVMF_BEGIN + OVMF_SIZE)
> > >  #define LOWCHUNK_BEGIN          0x000F0000
> > 



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel