Re: [Xen-devel] [PATCH RFC 4/4] hvmloader:ovmf: setup E820 map

[Ian Campbell <Ian.Campbell@xxxxxxxxxx>]

On Wed, 2013-11-20 at 11:58 +0000, Wei Liu wrote:
> On Wed, Nov 20, 2013 at 11:51:50AM +0000, Ian Campbell wrote:

> > Regardless of what the OVMF code does I think the e820 table which
> > hvmloader passes through should attempt to accurately describe what
> > hvmloader has done.
> > 
> 
> It is a bit confusing that SeaBIOS codes is relying on SeaBIOS to
> reserve certain region. I just followed suit.

Is it? The hvmloader seabios bindings are calling e820_build_table with
"0x100000-sizeof(seabios)" which is supposed to reserve the BIOS region.
(aside: that really ought to be ->bios_address!)

Or is there some other region which hvmloader sets up which needs
reserving?

It's ok for the BIOS to end up reserving more, based on the setup which
it does, of course. I think that is what the comment is referring too --
the fact that SeaBIOS reserves what it allocates. This is in contrast to
ROMBIOS which assumes hvmloader will create an e820 which it likes -- a
relic of the previous tight integration between hvmloader and seabios.

Ian.


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel