[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [Patch v4 1/4] x86/stack: Refactor show_trace()

>>> On 20.11.13 at 15:11, Andrew Cooper <andrew.cooper3@xxxxxxxxxx> wrote:
> I am not so certain about changing the _show_trace() prototype.  The
> naive algorithm wants everything as pointers, while the frame-pointer
> algorithm wants everything as integers.  Switching to passing by pointer
> would require an equal amount of ugly casting back to an integer for
> get_printable_stack_bottom() etc.
> Personally I would prefer to keep as integers to be in line with the
> registers;  I think it looks more natural to take sp as a resister value
> and cast it to a pointer to look at the stack, than passing around a
> pointer and casting it to an integer for bounds.

Fine with me, this was just a suggestion.


Xen-devel mailing list



Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.