Re: [Xen-devel] [PATCH] hotplug/Linux: update to new ip command syntax.

[Ian Campbell <Ian.Campbell@xxxxxxxxxx>]

On Wed, 2013-11-20 at 14:37 +0000, Ian Jackson wrote:
> Ian Campbell writes ("Re: [Xen-devel] [PATCH] hotplug/Linux: update to new ip 
> command syntax."):
> > On Mon, 2013-08-19 at 18:01 +0100, Ian Campbell wrote:
> > > On Mon, 2013-08-19 at 17:44 +0100, Ian Jackson wrote:
> > > > Do we know whether this new syntax is backwards-compatible ?
> > > 
> > > Good question. Squeeze's ip(8) doesn't mention dev for "ip link show" in
> > > the synopsis by virtue of not defining DEVICE anywhere but it does show
> > > the use of dev later on and the tool accepts it. Likewise for "ip link
> > > set". Given this, as Mike says, makes it impossible to name a device
> > > "dev" it seems likely to be a documentation bug.
> > > 
> > > "ip addr flush" is correctly documented as needing the dev (by saying
> > > "dev STRING" and not "DEVICE" , I didn't try without but I assume it
> > > works since our scripts do that right now.
> > > 
> > > I wasn't easily able to come up with an older machine.
> > 
> > Ian, was that a satisfactory explanation?
> 
> Yes, it was.  Sorry.
> 
> Acked-by: Ian Jackson <ian.jackson@xxxxxxxxxxxxx>

Thanks.

Now, WRT 4.4...

With reference to bugs.debian.org/cgi-bin/bugreport.cgi?bug=705659 the
patch allows the creation of a vif named "dev". Which although I'm sure
useful it is easily worked around. But on the other hand we are early in
the freeze and this could easily be considered a bug fix.

At this stage I'm leaning towards say lets take it.

Ian.


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel