[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Xen-devel] çåï Re: [PATCH v2 0/3] libxl: event system: SIGCHLD related fixes

>>> Jim Fehlig  2013-11-20 äå 12:29 >>>
> Ian Jackson wrote:
> > libxl's SIGCHLD handler is broken if libxl_sigchld_owner_libxl_always
> > and does not always work correctly with the fd registration system.
> >
> >  1/3 libxl: event system: pass gc, not just ctx, to internal
> >  2/3 libxl: event system: Make
> >  3/3 libxl: event system: properly register the SIGCHLD
> >
> > This is v2 of this series because when I reviewed it myself I found
> > that there was a critical missing ! in perhaps_removehandler, which
> > would remove the handler iff it was needed.  IMO this shows the
> > weakness of my testing arrangements.
> >
> > I'd really appreciate some feedback on this from Bamvor or Jim.
> >   

> Hrm, I haven't followed this thread and am not familiar with the details...
> Bamvor, have you reviewed/tested Ian's patches to see if they resolve
> the issue you originally raised in this thread?
sorry for late response.
i write a patch in libvirt in which use ao_how without callback and let libxl
manage the child. 
so fat i test create, save, restore successful. there is a dead-lock in libvirt 
when i
issue shutdown, i will deal with it tomorrow.

> Thanks,
> Jim

Xen-devel mailing list



Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.