[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Xen-devel] xen-4.3.1:hvm.c: 2 * possible bad if tests ?



Hello there,

I just ran the source code of xen-4.3.1 through the static analyser "cppcheck".

It said

1.

[hvm.c:2190]: (style) Expression '(X & 0xc00) != 0x6' is always true.

Source code is

            if ( ((desc.b & (6u<<9)) != 6) && (dpl != rpl) )
                goto unmap_and_fail;

You might be better off with

            if ( ((desc.b & (6u<<9))) && (dpl != rpl) )
                goto unmap_and_fail;

2.

[hvm.c:2210]: (style) Expression '(X & 0xc00) != 0x6' is always true.

Source code is

            if ( ((desc.b & (6u<<9)) != 6) && ((dpl < cpl) || (dpl < rpl)) )
                goto unmap_and_fail;

Duplicate.

Regards

David Binderman                                           
_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel


 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.