[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [GIT PULL) for-4.4.tmem - cleanups in the tmem code.



>>> On 12.11.13 at 16:22, Konrad Rzeszutek Wilk <konrad.wilk@xxxxxxxxxx> wrote:
> Hey Keir, et al,
> 
> Please git pull the following tree:
> 
> git://xenbits.xen.org/people/konradwilk/xen.git for-4.4.tmem

I pulled this, but ...

> which has cleanups to the tmem code. The pathces had been posted
> by Bob before the feature freeze date:
> 
>  http://article.gmane.org/gmane.comp.emulators.xen.devel/177431 
> 
> and I am as the maintainer of tmem happy with them. They
> make the code easier to read - thought there is still more
> work needed in that area.
> 
> I don't have write access to the proper git tree so was wondering
> if you would be so kind to merge it in at your convenience.
> 
> Thank you!
> 
>  xen/common/tmem.c          | 853 
> +++++++++++++++++++++++----------------------
>  xen/common/tmem_xen.c      | 171 +++------
>  xen/include/public/tmem.h  |   3 +-
>  xen/include/xen/tmem_xen.h | 251 ++++---------
>  4 files changed, 543 insertions(+), 735 deletions(-)
> 
> Bob Liu (11):
>       tmem: cleanup: drop COMPARE_COPY_PAGE_SSE2
>       tmem: cleanup: drop typedef pfp_t
>       tmem: cleanup: drop typedef tmem_cli_mfn_t

... I don't think this one is really appropriate: We shouldn't be
dropping things from public headers, as we don't know whether
there are people using such stuff.

Jan

>       tmem: cleanup: rename 'tmh_' with 'tmem_'
>       tmem: cleanup: drop most of the typedefs
>       tmem: cleanup: drop function tmem_alloc/free_infra
>       tmem: cleanup: drop typedef tmem_client_t
>       tmem: cleanup: drop useless wrap functions
>       tmem: cleanup: drop unused function 'domain_fully_allocated'
>       tmem: cleanup: drop useless '_subpage' wrap functions
>       tmem: cleanup: drop useless functions
> 
> 
> _______________________________________________
> Xen-devel mailing list
> Xen-devel@xxxxxxxxxxxxx 
> http://lists.xen.org/xen-devel 




_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel


 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.