[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [PATCH] xen: arm: remove /xen-core-devices node from dom0 dtb

On Fri, 2013-11-22 at 15:08 +0000, Julien Grall wrote:
> On 11/22/2013 03:05 PM, Ian Campbell wrote:
> > On Fri, 2013-11-22 at 14:58 +0000, Ian Campbell wrote:
> >>> BTW, the name of the argument "parent" is wrong. It's not the parent but
> >>> the current node. I would rename to "np".
> >>
> >> OK.
> >
> > Actually, everywhere else is using parent too. I'll fix this separatly.
> >
> What do you mean by everywhere else ? It's logic to use "parent" for the 
> hypervisor node and PSCI node. Because we will create it under the 
> parent node.
> Here, we know that we are replacing inplace the GIC, so it's the current 
> node.

Oh of course, that makes sense I guess.

I sent out the fixup already, where I also replaced all the np with node
because it was that name which lead to the confusion ("node parent").
I'll respin


Xen-devel mailing list



Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.