[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [PATCH v2 12/15] xen: arm: enable synchronous console while starting secondary CPUs

On Fri, 2013-11-22 at 17:36 +0000, Julien Grall wrote:

> > +    console_start_sync(); /* Secondary may use early_printk */
> > +
> I though have asked on the first version this question:

Sorry, don't remember seeing this.

> early printk is only enabled when CONFIG_EARLY_PRINTK is defined. Why 
> don't you surround console_*_sync with #ifdef CONFIG_EARLY_PRINTK?

I don't see any need, it is harmless even if !early_printk and it just
adds clutter to this function to ifdef it.


Xen-devel mailing list



Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.