Re: [Xen-devel] [V2 PATCH 1/8] PVH dom0: iommu related changes

["Jan Beulich" <JBeulich@xxxxxxxx>]

>>> On 23.11.13 at 01:03, Mukesh Rathor <mukesh.rathor@xxxxxxxxxx> wrote:
> --- a/xen/drivers/passthrough/iommu.c
> +++ b/xen/drivers/passthrough/iommu.c
> @@ -125,15 +125,27 @@ int iommu_domain_init(struct domain *d)
>      return hd->platform_ops->init(d);
>  }
>  
> +static __init void check_dom0_pvh_reqs(struct domain *d)
> +{
> +    if ( !iommu_enabled )
> +        panic("Presently, iommu must be enabled for pvh dom0\n");
> +
> +    if ( iommu_passthrough )
> +        panic("For pvh dom0, dom0-passthrough must not be enabled\n");
> +}
> +
>  void __init iommu_dom0_init(struct domain *d)
>  {
>      struct hvm_iommu *hd = domain_hvm_iommu(d);
>  
> +    if ( is_pvh_domain(d) )
> +        check_dom0_pvh_reqs(d);
> +
>      if ( !iommu_enabled )
>          return;
>  
>      register_keyhandler('o', &iommu_p2m_table);
> -    d->need_iommu = !!iommu_dom0_strict;
> +    d->need_iommu = is_pvh_domain(d) || !!iommu_dom0_strict;

I'd prefer if you simply forced iommu_dom0_strict on in
check_dom0_pvh_reqs().

Jan


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel