Re: [Xen-devel] [PATCH] xen/panic: Fix string inconsistencies in callers of panic()

[Ian Campbell <Ian.Campbell@xxxxxxxxxx>]

On Mon, 2013-11-25 at 10:06 +0000, Andrew Cooper wrote:
> panic() (as well as early_panic() in arm) is inconsistently called with or
> without a trailing newline.  This results in cases where the lower line of
> *****s is not on its own line.
> 
> Change panic() to always print a newline itself, and update callers not to.
> 
> In addition, panic() was occasionally called with a leading newline, and
> occaionally with trailing punctuation which seems rather redundant given the
> surrounding context.  Fix up these sitiuations as well.
> 
> Signed-off-by: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
> CC: Keir Fraser <keir@xxxxxxx>
> CC: Jan Beulich <JBeulich@xxxxxxxx>
> CC: Ian Campbell <ian.campbell@xxxxxxxxxx>
> CC: Stefano Stabellini <stefano.stabellini@xxxxxxxxxx>
> CC: Tim Deegan <tim@xxxxxxx>
> CC: George Dunlap <george.dunlap@xxxxxxxxxxxxx>

I'm not entirely sure I agree with nuking the trailing full stop from
all of the sentences, especially those which are a complete sentence.

But unless others feel the same I'm not inclined to argue:
Acked-by: Ian Campbell <ian.campbell@xxxxxxxxxx>




_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel