[Xen-devel] [PATCH 2/2] tools/xenconsoled: Fix file handle leaks

[Andrew Cooper <andrew.cooper3@xxxxxxxxxx>]

Coverity ID: 715218 1055876 1055877

Signed-off-by: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
CC: Ian Campbell <Ian.Campbell@xxxxxxxxxx>
CC: Ian Jackson <Ian.Jackson@xxxxxxxxxxxxx>
---
 tools/console/daemon/io.c    |    2 ++
 tools/console/daemon/utils.c |    1 +
 2 files changed, 3 insertions(+)

diff --git a/tools/console/daemon/io.c b/tools/console/daemon/io.c
index 250550a..007ecf4 100644
--- a/tools/console/daemon/io.c
+++ b/tools/console/daemon/io.c
@@ -278,6 +278,7 @@ static int create_hv_log(void)
                        dolog(LOG_ERR, "Failed to log opening timestamp "
                                       "in %s: %d (%s)", logfile, errno,
                                       strerror(errno));
+                       close(fd);
                        return -1;
                }
        }
@@ -323,6 +324,7 @@ static int create_domain_log(struct domain *dom)
                        dolog(LOG_ERR, "Failed to log opening timestamp "
                                       "in %s: %d (%s)", logfile, errno,
                                       strerror(errno));
+                       close(fd);
                        return -1;
                }
        }
diff --git a/tools/console/daemon/utils.c b/tools/console/daemon/utils.c
index aab6f42..71dd185 100644
--- a/tools/console/daemon/utils.c
+++ b/tools/console/daemon/utils.c
@@ -104,6 +104,7 @@ void daemonize(const char *pidfile)
        signal(SIGTSTP, SIG_IGN);
        signal(SIGTTOU, SIG_IGN);
        signal(SIGTTIN, SIG_IGN);
+       close(fd);
 }
 
 bool xen_setup(void)
-- 
1.7.10.4


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel