[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [PATCH 3/5] tools/libxc: Improve xc_dom_malloc_filemap() error handling

Andrew Cooper writes ("[PATCH 3/5] tools/libxc: Improve xc_dom_malloc_filemap() 
error handling"):
> Coverity ID 1055563
> In the original function, mmap() could be called with a length of -1 if the
> second lseek failed and the caller had not provided max_size.
> While fixing up this error, improve the logging of other error paths.  I know
> from personal experience that debugging failures function is rather difficult
> given only "xc_dom_malloc_filemap: failed (on file <somefile>)" in the logs.
> Signed-off-by: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
> CC: Ian Campbell <Ian.Campbell@xxxxxxxxxx>

Acked-by: Ian Jackson <ian.jackson@xxxxxxxxxxxxx>
Committed-by: Ian Jackson <ian.jackson@xxxxxxxxxxxxx>

Xen-devel mailing list



Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.