Re: [Xen-devel] [PATCH 1/4] tools/libxl: Avoid deliberate NULL pointer dereference

[Ian Jackson <Ian.Jackson@xxxxxxxxxxxxx>]

Andrew Cooper writes ("[PATCH 1/4] tools/libxl: Avoid deliberate NULL pointer 
dereference"):
> Coverity ID: 1055290
> 
> Calling LIBXL__LOG_ERRNO(ctx,) with a ctx pointer we have just failed to
> allocate is going to end badly.  Opencode a suitable use of xtl_log() instead.
> 
> Signed-off-by: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
> CC: Ian Campbell <Ian.Campbell@xxxxxxxxxx>

Acked-by: Ian Jackson <ian.jackson@xxxxxxxxxxxxx>
Committed-by: Ian Jackson <ian.jackson@xxxxxxxxxxxxx>

This patch is correct, although the usual approach in libxl would be
to crash by calling libxl__alloc_failed.  It would be possible to do
this in libxl_ctx_init by allocating a dummy ctx on the stack.

Ian.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel