[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [PATCH v2 2/2] libxl: Fix nographic with upstream qemu

2013/11/25 Anthony PERARD <anthony.perard@xxxxxxxxxx>
On Tue, Nov 19, 2013 at 03:57:09PM +0100, Fabio Fantoni wrote:
> Fix xl nographic parameter with upstream qemu using vga none
> instead of -nographic qemu parameter not working anymore and
> deprecated.
> Changes from v1:
> - libxl_create.c:
>  - add vga=none if nographic=1 only with upstream qemu
>  - move setdefault of nographic up, otherwise xl create will
>    fail if nographic xl paramter is not set

Could you tell me where it is said that -nographic is deprecated?

On one old qemu-devel post if I remember good, I not found it now with fast search.

Also, I've did few tests, and it look like nographic=1 still works well.

When I did a tests time ago with upstream qemu gave always cirrus vga with hvm domUs, also with vga and stdvga not setted and nographic on.
Tried also removing my patches about -nodefaults but same result.
When I did this patches I found that xl setted cirrus in any case and also with -nographic with upstream qemu not override -vga or -device.

In QEMU, "-vga none" and "-nographic" are two different things. The
first parameter disable the graphic emulation, which mean you can have a
guest without graphic card (lspci will show that). The second one is to
disable any graphic output (sdl, vnc, ...).

The only issue might be the documentation.

Sorry, about qemu traditional I haven't well documented, but on this patch I setted nographic equivalent to vga none only with upstream qemu, so the qemu-trad remain correctly.
Another note, I use spice with upstream qemu instead of vnc (because is largely better), probably -nographic not disable it.

Sumarizing, previous patch about vga none after new version following your advice can be useful in any case.
About nographic instead
I am doubtful about how to proceed, I think, however that an improvements and/or more documentations are needed.
Ideas or tips about nographic?

Thanks for any reply and sorry for my bad english.


Anthony PERARD

Xen-devel mailing list



Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.