[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [PATCH 5/5] xenstat: Fix buffer over-run with new_domains being negative (again).

On Mon, 2013-11-25 at 17:36 +0000, Andrew Cooper wrote:
> xc_domain_getinfolist() is just as crazy as its partner in crime,
> xc_domain_getinfo(), and takes an unsigned int "max_doms" and returns a
> signed number of domains gotten, or -1 for certain failed hypercalls.

Perhaps we should be changing those two to take a signed int max? The
domid_t typedef might be a suitable type.

For evtchns we have evtchn_port_or_error_t to cover the -1..2^16 space,
we could do something similar here for the return type, or just leave it
as is.

Xen-devel mailing list



Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.