[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] Re: [Xen-devel] [PATCH 1/2] firmware/tcgbios: Prevent integer truncation in the return value
On Mon, 2013-11-25 at 11:04 +0000, Andrew Cooper wrote: > rc inside the function is uint32_t. None of the callers check the return > value. Makes me wonder if chaigng to returning void might have been better, but any way, I acked and applied this and hte second one. > > Coverity ID: 1055442 > > Signed-off-by: Andrew Cooper <andrew.cooper3@xxxxxxxxxx> > CC: Keir Fraser <keir@xxxxxxx> > CC: Jan Beulich <JBeulich@xxxxxxxx> > CC: Ian Campbell <Ian.Campbell@xxxxxxxxxx> > CC: Ian Jackson <Ian.Jackson@xxxxxxxxxxxxx> > --- > tools/firmware/rombios/32bit/tcgbios/tcgbios.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/tools/firmware/rombios/32bit/tcgbios/tcgbios.c > b/tools/firmware/rombios/32bit/tcgbios/tcgbios.c > index d5e2202..01d4f2f 100644 > --- a/tools/firmware/rombios/32bit/tcgbios/tcgbios.c > +++ b/tools/firmware/rombios/32bit/tcgbios/tcgbios.c > @@ -428,7 +428,7 @@ uint32_t tcpa_get_laml(void) > * data : pointer to the data (i.e., string) to be added to the log > * length : length of the data > */ > -static uint16_t > +static uint32_t > tcpa_add_measurement_to_log(uint32_t pcrIndex, > uint32_t event_type, > uint32_t event_id, _______________________________________________ Xen-devel mailing list Xen-devel@xxxxxxxxxxxxx http://lists.xen.org/xen-devel
|
Lists.xenproject.org is hosted with RackSpace, monitoring our |