Re: [Xen-devel] [Patch v2 1/2] xen/compiler: Replace opencoded __attribute__((noreturn))

[George Dunlap <George.Dunlap@xxxxxxxxxxxxx>]

On Mon, Nov 25, 2013 at 2:02 PM, Andrew Cooper
<andrew.cooper3@xxxxxxxxxx> wrote:
> Make a formal define for noreturn in compiler.h, and fix up opencoded uses of
> __attribute__((noreturn)).  This includes removing redundant uses with
> function definitions which have a public declaration.
>
> There is a stale statement in sh_skip_sync(); BUG() now contains
> unreachable(), removing the justification for having "return 0".
>
> Signed-off-by: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
> CC: Keir Fraser <keir@xxxxxxx>
> CC: Jan Beulich <JBeulich@xxxxxxxx>
> Acked-by: Ian Campbell <ian.campbell@xxxxxxxxxx>
> CC: Stefano Stabellini <stefano.stabellini@xxxxxxxxxx>
> Acked-by: Tim Deegan <tim@xxxxxxx>

So the #ifdef part of this patch should be as safe as anything can be;
but on the other hand, it's not really that much benefit either -- the
source code is a tiny, tiny bit cleaner, that's all.

Removing redundant definitions again gets into going down different
paths in the compiler for a niche optimization feature, and again the
only benefit is that the code is a tiny bit cleaner.

I really don't see any reason this patch can't wait until 4.5.

Removing the unused function prototype (mentioned in the discussion of
the other patch) seems sensible.

 -George

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel