Re: [Xen-devel] [PATCH 2/2] use return value of domain_adjust_tot_pages() where feasible

[George Dunlap <george.dunlap@xxxxxxxxxxxxx>]

On 11/27/2013 08:26 AM, Jan Beulich wrote:
> This is generally cheaper than re-reading ->tot_pages.
>
> While doing so I also noticed an improper use (lacking error handling)
> of get_domain() as well as lacks of ->is_dying checks in the memory
> sharing code, which the patch fixes at once. In the course of doing
> this I further noticed other error paths there pointlessly calling
> put_page() et al with ->page_alloc_lock still held, which is also being
> reversed.
Thus hiding two very important changes underneath a summary that looks 
completely unimportant.
If this patch only did as the title suggests, I would question whether 
it should be included for 4.4, since it seems to have little benefit.  
Are the other two changes bug fixes?
In any case, the summary should indicate to someone just browsing 
through what important changes might be inside.
 -George


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel