Re: [Xen-devel] [PATCH v3 2/8] OvmfPkg: introduce E820.h

[Wei Liu <wei.liu2@xxxxxxxxxx>]

On Wed, Nov 27, 2013 at 04:18:38PM -0800, Jordan Justen wrote:
> On Wed, Nov 27, 2013 at 4:22 AM, Wei Liu <wei.liu2@xxxxxxxxxx> wrote:
> > On Tue, Nov 26, 2013 at 02:47:13PM -0500, Konrad Rzeszutek Wilk wrote:
> >> On Tue, Nov 26, 2013 at 07:25:58PM +0000, Wei Liu wrote:
> >> > E820 definitions copied from IntelFrameworkModulePkg/Csm/
> >> > LegacyBiosDxe/LegacyBiosInterface.h.
> >> >
> >> > Contributed-under: TianoCore Contribution Agreement 1.0
> >> > Signed-off-by: Wei Liu <wei.liu2@xxxxxxxxxx>
> >> > Reviewed-by: Jordan Justen <jordan.l.justen@xxxxxxxxx>
> >> > ---
> >> >  OvmfPkg/Include/IndustryStandard/E820.h |   46 
> >> > +++++++++++++++++++++++++++++++
> >> >  1 file changed, 46 insertions(+)
> >> >  create mode 100644 OvmfPkg/Include/IndustryStandard/E820.h
> >> >
> >> > diff --git a/OvmfPkg/Include/IndustryStandard/E820.h 
> >> > b/OvmfPkg/Include/IndustryStandard/E820.h
> >> > new file mode 100644
> >> > index 0000000..e7e0c25
> >> > --- /dev/null
> >> > +++ b/OvmfPkg/Include/IndustryStandard/E820.h
> >> > @@ -0,0 +1,46 @@
> >> > +/** @file
> >> > +
> >> > +Copyright (c) 2006 - 2013, Intel Corporation. All rights reserved.<BR>
> >>
> >> <BR> ?
> >>
> >
> > Copy-n-paste error, phew.
> >
> > <BR> stands for new line in HTML. I have no idea how it came up in the
> > original header.
> 
> Actually Intel wants that appended to all Intel copyright lines in EDK II 
> files.
> 
> I'm not sure why, but I suspected something related to forcing a
> newline in doxygen.
> 
> Hot seems to keep an eye on it, so maybe he knows.
> 

Oh that's really unusal requirement. ;-)

> -Jordan
> 
> >> > +Copyright (c) 2013, Citrix Systems UK Ltd.
> >> > +

In that case should I append <BR> to the above line?

Hot, can you clarify this to a humble non-Intel developer? :-P

Thanks
Wei.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel