[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [PATCH v5 03/12] libxl: ocaml: event management

Rob Hoes writes ("[PATCH v5 03/12] libxl: ocaml: event management"):
> Having bindings to the low-level functions libxl_osevent_register_hooks and
> related, allows to run an event loop in OCaml; either one we write ourselves,
> or one that is available elsewhere.
> The Lwt cooperative threads library (http://ocsigen.org/lwt/), which is quite
> popular these days, has an event loop that can be easily extended to poll any
> additional fds that we get from libxl. Lwt provides a "lightweight" threading
> model, which does not let you run any other (POSIX) threads in your
> application, and therefore excludes an event loop implemented in the C
> bindings.

Subject to my comments on with the locking change patch, I think this
one is OK _if that patch goes in as well_.

Formally speaking that means I shouldn't ack this patch, because
partial application of a series is supposed to still leave the tree
correct.  Or to put it another way, it's a bit odd to find that this
patch introduces wrong code which is to be fixed up later.

Having said that, I don't think much would be served by asking you to
transpose these patches at this stage, even though it would be
preferable.  And I have no other problems with this.  So:

CONDITIONAL Acked-by: Ian Jackson <ian.jackson@xxxxxxxxxxxxx>

The condition is that
  "libxl: ocaml: drop the ocaml heap lock before calling into libxl"
is committed and pushed simultaneously.


Xen-devel mailing list



Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.