Re: [Xen-devel] [PATCH v6 08/12] libxl: ocaml: drop the ocaml heap lock before calling into libxl

[Rob Hoes <Rob.Hoes@xxxxxxxxxx>]

Ian Jackson wrote:
> Ian Campbell writes ("Re: [PATCH v6 08/12] libxl: ocaml: drop the ocaml
> heap lock before calling into libxl"):
> > On Wed, 2013-11-27 at 13:49 +0000, Rob Hoes wrote:
> > > This fall into the "copying ocaml values to C before dropping the
> > > ocaml lock" category: it avoids calling the aohow_val function
> > > inside the argument list of the libxl functions, which are called
> > > without the ocaml lock.
> >
> > I see, I'd have done it with stack_ao_how and *ao_how as the return
> > value rather than dynamic allocation but OK.
> 
> I don't think this change is actually logically interconnected with the
> locking changes.  See my other mail just sent.

As I see it, the locking changes did require this to be changed. I hope my 
reply to the other mail makes it clear.

Rob

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel