Re: [Xen-devel] [PATCH v4 1/4] hvmloader/ovmf: remove hardcoded OVMF loading location

[Ian Campbell <Ian.Campbell@xxxxxxxxxx>]

On Tue, 2013-11-26 at 19:31 +0000, Wei Liu wrote:
> Load OVMF from (100000000ULL - sizeof(ovmf)) to 0xFFFFFFFF, with proper
> rounding down.
> 
> Tested with OVMF release build (1 MB) and debug build (2 MB), both
> worked fine.
> 
> Signed-off-by: Wei Liu <wei.liu2@xxxxxxxxxx>

Acked-by: Ian Campbell <ian.campbell@xxxxxxxxxx>

I applied this and #2. #3 and #4 I think need to wait for the struct to
be finally agreed with ovmf.

> ---
>  tools/firmware/hvmloader/ovmf.c |    4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/tools/firmware/hvmloader/ovmf.c b/tools/firmware/hvmloader/ovmf.c
> index ee4cbbf..148102a 100644
> --- a/tools/firmware/hvmloader/ovmf.c
> +++ b/tools/firmware/hvmloader/ovmf.c
> @@ -38,9 +38,9 @@
>  #define ROM_INCLUDE_OVMF
>  #include "roms.inc"
>  
> -#define OVMF_BEGIN              0xFFF00000ULL
> -#define OVMF_SIZE               0x00100000ULL
> +#define OVMF_SIZE               (sizeof(ovmf))
>  #define OVMF_MAXOFFSET          0x000FFFFFULL
> +#define OVMF_BEGIN              (0x100000000ULL - ((OVMF_SIZE + 
> OVMF_MAXOFFSET) & ~OVMF_MAXOFFSET))
>  #define OVMF_END                (OVMF_BEGIN + OVMF_SIZE)
>  #define LOWCHUNK_BEGIN          0x000F0000
>  #define LOWCHUNK_SIZE           0x00010000




_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel