Re: [Xen-devel] arm: double EXPORT_SYMBOL(cpu_online_map);

[Ian Campbell <Ian.Campbell@xxxxxxxxxx>]

On Thu, 2013-11-21 at 10:53 +0000, Ian Campbell wrote:
> On Tue, 2013-11-19 at 10:36 +0000, Ian Campbell wrote:
> > On Fri, 2013-11-15 at 14:50 +0000, Stefano Stabellini wrote:
> > > On Fri, 15 Nov 2013, Dietmar Hahn wrote:
> > > > Hi,
> > > > 
> > > > I dont' know the arm architecture but while searching the code I found 
> > > > the
> > > > following copy failure I think:
> > > > 
> > > > Dietmar.
> > > > 
> > > 
> > > 
> > > Acked-by: Stefano Stabellini <stefano.stabellini@xxxxxxxxxxxxx>
> > 
> > EXPORT_SYMBOL is meaningless in Xen and provided only for compatibility
> > with code taken from Linux. But our smpboot.c is not taken from Linux, I
> > expect we blindly inherited them from the x86 version (which has also
> > long since diverged).
> > 
> > I think we can just nuke them.
> 
> Like so:
> 
> 8>-------------
> 
> From 5f5cc43a23b89f095b00f654c698e85875d01998 Mon Sep 17 00:00:00 2001
> From: Ian Campbell <ian.campbell@xxxxxxxxxx>
> Date: Thu, 21 Nov 2013 10:49:14 +0000
> Subject: [PATCH] xen: arm: Remove useless and incorrect EXPORT_SYMBOLS
> 
> Dietmar noticed that one of these was incorrect, but in actual fact they are
> not even used. They are defined as nops in Xen for the benefit of code
> imported to Linux which ARM's smpboot.c is not.
> 
> Just get rid of them.
> 
> Reported-by: Dietmar Hahn <dietmar.hahn@xxxxxxxxxxxxxx>
> Signed-off-by: Ian Campbell <ian.campbell@xxxxxxxxxx>

This is so trivial I've just applied it.



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel