Re: [Xen-devel] [PATCH v3 2/7] x86: handle CQM resource when creating/destroying guests

["Jan Beulich" <JBeulich@xxxxxxxx>]

>>> On 29.11.13 at 15:18, Andrew Cooper <andrew.cooper3@xxxxxxxxxx> wrote:
> On 29/11/13 05:48, dongxiao.xu@xxxxxxxxx wrote:
>> --- a/xen/common/domctl.c
>> +++ b/xen/common/domctl.c
>> @@ -425,7 +425,8 @@ long do_domctl(XEN_GUEST_HANDLE_PARAM(xen_domctl_t) 
>> u_domctl)
>>                 | XEN_DOMCTL_CDF_pvh_guest
>>                 | XEN_DOMCTL_CDF_hap
>>                 | XEN_DOMCTL_CDF_s3_integrity
>> -               | XEN_DOMCTL_CDF_oos_off)) )
>> +               | XEN_DOMCTL_CDF_oos_off
>> +               | XEN_DOMCTL_CDF_pqos_cqm)) )
> 
> If you move the final bracket onto a new line now, future additions will
> be a single line addition rather than one removal and two additions.

I'd rather not - a lone closing parenthesis on a line looks pretty
odd, sort of calling for being cleaned up.

Jan


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel