Re: [Xen-devel] [PATCH v4 4/4] hvmloader/ovmf: setup E820 map

[Wei Liu <wei.liu2@xxxxxxxxxx>]

On Sat, Nov 30, 2013 at 04:05:10PM -0800, Jordan Justen wrote:
> On Tue, Nov 26, 2013 at 11:31 AM, Wei Liu <wei.liu2@xxxxxxxxxx> wrote:
> > E820 map will be used by OVMF to create memory map.
> >
> > Signed-off-by: Wei Liu <wei.liu2@xxxxxxxxxx>
> > ---
> >  tools/firmware/hvmloader/ovmf.c |   13 ++++++++++++-
> >  1 file changed, 12 insertions(+), 1 deletion(-)
> >
> > diff --git a/tools/firmware/hvmloader/ovmf.c 
> > b/tools/firmware/hvmloader/ovmf.c
> > index d536501..3f8cf3e 100644
> > --- a/tools/firmware/hvmloader/ovmf.c
> > +++ b/tools/firmware/hvmloader/ovmf.c
> > @@ -137,6 +137,17 @@ static void ovmf_create_smbios_tables(void)
> >          SMBIOS_PHYSICAL_END);
> >  }
> >
> > +static void ovmf_setup_e820(void)
> > +{
> > +    struct ovmf_info *info = (void *)OVMF_INFO_PHYSICAL_ADDRESS;
> > +    struct e820entry *e820 = scratch_alloc(sizeof(struct e820entry)*16, 0);
> > +    info->e820 = (uint32_t)e820;
> 
> uint32_t => uintptr_t?
> 

I think following SeaBIOS convention is good enough at this stage. We
don't have uintptr_t now, everything has explicit size.

Wei.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel