Re: [Xen-devel] [PATCH] libxenctrl: Fix xc_interface_close() crash if it gets NULL as an argument

[Ian Campbell <Ian.Campbell@xxxxxxxxxx>]

On Mon, 2013-12-02 at 20:13 +0100, Daniel Kiper wrote:
> xc_interface_close() crashes if it gets NULL as an argument. However,
> it just calls xc_interface_close_common() which is called by many
> others functions. It means that they are also vulnerable. So fix above
> mentioned issue by adding NULL check in xc_interface_close_common().
> This way we fix similar issue in other functions which calls
> xc_interface_close_common() too.
> 
> Signed-off-by: Daniel Kiper <daniel.kiper@xxxxxxxxxx>

I suppose this makes sense in the same way that free(NULL) does:
        Acked-by: Ian Campbell <ian.campbell@xxxxxxxxxx>

Did you observe this with a particular caller?



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel