[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [PATCH v2] xen: arm: remove hardcoded gnttab location from dom0

On Wed, 2013-12-04 at 17:03 +0000, Ian Campbell wrote:
> The DT provided to guests (including dom0) includes a Xen node which, among
> other things, describes an MMIO region which can be safely used for grant
> table mappings (i.e. it is a hole in the physical address space). For domU we
> provide a hardcoded values based on our hardcoded guest virtual machine
> layout. However for dom0 we need to fit in with the underlying platform.
> Leaving this hardcoded was an oversight which on some platforms could result
> in the grant table overlaying RAM or MMIO regions which are in use by domain
> 0.
> For the 4.4 release do as we did with the dom0 evtchn PPI and provide a hook
> for the platform code to supply a suitable hardcoded address for the platform
> (derived from reading the data sheet). Platforms which do not provide the hook
> get the existing address as a default.
> After 4.4 we should switch to selecting a region of host RAM which is not RAM
> in the guest address map. This should be more flexible and safer but the patch
> was looking too complex for 4.4.
> Platform        Gnttab Address
> ========        ==============
> exynos5.c       0xb0000000, confirmed and tested by Julien.
> sunxi.c         0x01d00000, confirmed in data sheet.
> midway.c        0xff800000, confirmed by Andre, boot tested by Ian.
> vexpress.c      0xb0000000, existing hardcoded value was selected for 
> vexpress.
> omap5.c         0x4b000000, confirmed by Baozi
> xgene-storm.c   0x1f800000, confirmed by Pranavkumar
> Signed-off-by: Ian Campbell <ian.campbell@xxxxxxxxxx>
> Tested-by: Julien Grall <julien.grall@xxxxxxxxxx>
> Acked-by: Julien.Grall@xxxxxxxxxx
> Cc: Stefano.Stabellini@xxxxxxxxxxxxx
> Cc: Andre Przywara <andre.przywara@xxxxxxxxxx>
> Acked-by: Chen Baozi <baozich@xxxxxxxxx>
> Acked-by: Pranavkumar Sawargaonkar <psawargaonkar@xxxxxxx>
> Cc: Anup Patel <apatel@xxxxxxx>

This is a bug fix, so I've applied it.

Xen-devel mailing list



Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.