Re: [Xen-devel] [PATCH] xen: arm: vtimer fixes for arm64

[Stefano Stabellini <stefano.stabellini@xxxxxxxxxxxxx>]

On Thu, 5 Dec 2013, Ian Campbell wrote:
> @@ -227,12 +242,18 @@ static int vtimer_emulate_sysreg(struct cpu_user_regs 
> *regs, union hsr hsr)
>      {
>      case CNTP_CTL_EL0:
>          vtimer_cntp_ctl(regs, &r, sysreg.read);
> -        *x = r;
> +        if ( sysreg.read )
> +            *x = r;
>          return 1;
>      case CNTP_TVAL_EL0:
>          vtimer_cntp_tval(regs, &r, sysreg.read);
> -        *x = r;
> +        if ( sysreg.read )
> +            *x = r;
>          return 1;

Are you sure that sysreg.read == 1 means write?
From xen/arch/arm/traps.c:do_sysreg:

        printk("%s %d, %d, c%d, c%d, %d %s x%d @ 0x%"PRIregister"\n",
               sysreg.read ? "mrs" : "msr",

sysreg.read == 1 -> mrs that is a read from special register.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel