Re: [Xen-devel] [PATCH RFC V2 4/6] Introduce ts-ovmf-debian-install

[Ian Jackson <Ian.Jackson@xxxxxxxxxxxxx>]

Dario Faggioli writes ("Re: [Xen-devel] [PATCH RFC V2 4/6] Introduce 
ts-ovmf-debian-install"):
> On gio, 2013-12-12 at 12:16 +0000, Wei Liu wrote:
> > $xl is in fact toolstack()->{Command}.
> 
> I know.

So err, I'm not sure what your point was.  Wei's code seems correct to
me.

> > > I don't know how important this is, though, as I don't think this has
> > > much chances to work with xend, has it?
> > 
> > No. Xend is deprecated so I don't bother fiddling with that.

I think it's better to be consistent and always use
toolstack()->{Command} even in tests which aren't going to work with
xend.

> > > Does this mean that the guest remains up after the end of the test? This
> > > is also probably not a big deal, but, shouldn't we tear it down?
> > 
> > I copied this from ts-redhat-install.
> >
> You're right, sorry for this. I thought I see gests being teared down
> somewhere, but just finished running a (similar) test myself, and the
> guest is up.

Whether the script leaves the guest up is a matter for the individual
script.  ts-debian-install && ts-debian-fixup leaves it down, but most
of the other ts-*-install scripts leave it up.  I don't think an
install script should do a shutdown just to provide a uniform interface.

The corresponding knowledge of whether to run start or not is in
sg-run-job.

Thanks,
Ian.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel