Re: [Xen-devel] [PATCH 3/3] libxl: ocaml: use 'for_app_registration' in osevent callbacks

[Ian Jackson <Ian.Jackson@xxxxxxxxxxxxx>]

Ian Campbell writes ("Re: [PATCH 3/3] libxl: ocaml: use 'for_app_registration' 
in osevent callbacks"):
> > @@ -1241,32 +1255,43 @@ int fd_modify(void *user, int fd, void 
> > **for_app_registration_update,
...
> > +   /* if for_app == NULL, assume that something is wrong and don't 
> > callback */
> > +   if (for_app) {
> 
> if (!for_app) {
>       cleanup
>       return;
> }

Why not
  assert(for_app)
?

> Actually, elsewhere you don't bother to check for_app. If this would
> indicate a major error then I think an assert would be perfectly
> reasonably.

:-).

Ian.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel