[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [PATCH v4 01/11] pvh dom0: Introduce p2m_map_foreign

On 12/13/2013 11:19 PM, Ian Campbell wrote:
On Fri, 2013-12-13 at 19:37 +0000, Julien Grall wrote:
From: Mukesh Rathor <mukesh.rathor@xxxxxxxxxx>

In this patch, a new type p2m_map_foreign is introduced for pages
that toolstack on PVH dom0 maps from foreign domains that its creating
or supporting during it's run time.

Signed-off-by: Mukesh Rathor <mukesh.rathor@xxxxxxxxxx>
Cc: Jan Beulich <jbeulich@xxxxxxxx>
Cc: Keir Fraser <keir@xxxxxxx>
Cc: George Dunlap <george.dunlap@xxxxxxxxxxxxx>

     Changes in v4:
         - Use the patch #4 from dom0 pvh v6 series. We need it for ARM

Is this really the right patch? I'd have thought it would need to
include some generic/!x86 bits but:

This patch introduce p2m_map_foreign type. I think it's safe to push it without the other patches. Moreover, it will avoid dummy #define p2m_is_foreign in my patch #8.

  xen/arch/x86/mm/p2m-ept.c |    1 +
  xen/arch/x86/mm/p2m-pt.c  |    1 +
  xen/arch/x86/mm/p2m.c     |   28 ++++++++++++++++++++--------
  xen/include/asm-x86/p2m.h |    4 ++++
  4 files changed, 26 insertions(+), 8 deletions(-)

Don't you want patch #6 from the PVH series instead?

I made a mistake in my cover letter. I was talking about patch #6 not #7. I have taken the common code in merge into my patch #8.

Julien Grall

Xen-devel mailing list



Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.