Re: [Xen-devel] [PATCH] xl: create VFB for PV guest when VNC is specified

[Wei Liu <wei.liu2@xxxxxxxxxx>]

On Mon, Dec 16, 2013 at 12:43:57PM +0000, Ian Jackson wrote:
> Wei Liu writes ("Re: [PATCH] xl: create VFB for PV guest when VNC is 
> specified"):
> > On Mon, Dec 16, 2013 at 12:17:02PM +0000, Ian Jackson wrote:
> > > Missing error check.
> > 
> > No call site ever error-checks this. Probably a separate patch to add
> > error check to all of them?
> 
> Maybe we should do something different.  E.g., make all these
> functions return void and stash the fact that there was an error away
> somewhere, and provide and call a new "was the5re an error" function.
> 
> That way if you write multiple errors in the file you get them
> reported all at once.
> 

IMHO this doesn't sound like 4.4 material, too big a patch for a bug
fix...

Wei.

> Ian.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel