Re: [Xen-devel] [PATCH 2/3] libxl: ocaml: use int64 for timeval fields in the timeout_register callback

[Ian Campbell <Ian.Campbell@xxxxxxxxxx>]

On Thu, 2013-12-12 at 18:32 +0000, Ian Jackson wrote:
> Ian Jackson writes ("RE: [PATCH 2/3] libxl: ocaml: use int64 for timeval 
> fields in the timeout_register callback"):
> > Well, that's too small for a timeval, which has a 32-bit seconds value
> > (currently using 31 of those bits and heaven help us when we get to
> > 0x80000000) and a ~30-bit nsecs value.
> 
> I'm thinking of timespecs not timevals.  But:
> 
> > > I guess we can probably get away with 32 bits for that one, based on what 
> > > we know the of the range of possible values. I'd just like to avoid any 
> > > possible trouble, and didn't think those extra bits would cause too much 
> > > harm.
> > 
> > Right.
> 
> I now think this is fine.

Sorry for not following along properly -- do you mean the original patch
is fine or that one of the other schemes discussed in this thread is
going to be OK once implemented?

Ian.



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel