Re: [Xen-devel] [PATCH v6 08/10] xen/arm: Add relinquish_p2m_mapping to remove reference on every mapped page

[Ian Campbell <Ian.Campbell@xxxxxxxxxx>]

On Tue, 2013-12-17 at 16:27 +0000, Julien Grall wrote:
> This function will be called when the domain relinquishes its memory.
> It removes refcount on every mapped page to a valid MFN.
> 
> Currently, Xen doesn't take reference on every new mapping but only for 
> foreign
> mapping. Restrict the function only on foreign mapping.
> 
> Signed-off-by: Julien Grall <julien.grall@xxxxxxxxxx>
> 
> ---
>     Changes in v6:
>         - Typoes
>         - Rework preempt
>         - Clean up if ( p2mt == ... || p2mt == ... )

You don't seem to have addressed the issue I pointed out about
create_p2m_entries exiting on any holes which it finds at the first or
second level.

I think you missed my second reply to 08/10 on v5 see:
<1387279904.27441.47.camel@xxxxxxxxxxxxxxxxxxxxxx>

Ian.



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel