[Xen-devel] [PATCH] qemu-traditional: Fix build warnings on Wheezy

[Andrew Cooper <andrew.cooper3@xxxxxxxxxx>]

  CC    i386-dm/eepro100.o
hw/eepro100.c: In function âeepro100_read4â:
hw/eepro100.c:1232:5: warning: âvalâ may be used uninitialized in this function 
[-Wmaybe-uninitialized]
hw/eepro100.c: In function âeepro100_read2â:
hw/eepro100.c:1202:5: warning: âvalâ may be used uninitialized in this function 
[-Wmaybe-uninitialized]
hw/eepro100.c: In function âeepro100_read1â:
hw/eepro100.c:1179:5: warning: âvalâ may be used uninitialized in this function 
[-Wmaybe-uninitialized]

Use ~0 to match the behaviour of real hardware.

Signed-off-by: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
CC: Ian Campbell <Ian.Campbell@xxxxxxxxxx>
CC: Ian Jackson <Ian.Jackson@xxxxxxxxxxxxx>

---

FWIW, Coverity does not appear to believe there is an exit path from these
functions with the uninitialised 'val'.
---
 hw/eepro100.c |    6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/hw/eepro100.c b/hw/eepro100.c
index bc6c3d5..d172b91 100644
--- a/hw/eepro100.c
+++ b/hw/eepro100.c
@@ -1136,7 +1136,7 @@ static void eepro100_write_port(EEPRO100State * s, 
uint32_t val)
 
 static uint8_t eepro100_read1(EEPRO100State * s, uint32_t addr)
 {
-    uint8_t val;
+    uint8_t val = ~0;
     if (addr <= sizeof(s->mem) - sizeof(val)) {
         memcpy(&val, &s->mem[addr], sizeof(val));
     }
@@ -1181,7 +1181,7 @@ static uint8_t eepro100_read1(EEPRO100State * s, uint32_t 
addr)
 
 static uint16_t eepro100_read2(EEPRO100State * s, uint32_t addr)
 {
-    uint16_t val;
+    uint16_t val = ~0;
     if (addr <= sizeof(s->mem) - sizeof(val)) {
         memcpy(&val, &s->mem[addr], sizeof(val));
     }
@@ -1204,7 +1204,7 @@ static uint16_t eepro100_read2(EEPRO100State * s, 
uint32_t addr)
 
 static uint32_t eepro100_read4(EEPRO100State * s, uint32_t addr)
 {
-    uint32_t val;
+    uint32_t val = ~0U;
     if (addr <= sizeof(s->mem) - sizeof(val)) {
         memcpy(&val, &s->mem[addr], sizeof(val));
     }
-- 
1.7.10.4


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel