[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [RFC 5/6] xen/console: Add noreturn attribute to panic function





On 01/05/2014 10:44 PM, Andrew Cooper wrote:
On 05/01/2014 21:26, Julien Grall wrote:
Panic function will never return. Without this attribute, gcc may output
warnings in call function.

Cc: Keir Fraser <keir@xxxxxxx>
Signed-off-by: Julien Grall <julien.grall@xxxxxxxxxx>

I have a longer series doing rather more noreturn'ing than just this, if
you can wait until the 4.5 dev window opens up again.

I'm not sure to get what you said. When early_panic is converted to panic function, I got some gcc warning which result in errors, because of -Werror.

So without this small patch, this series can't compile.

--
Julien Grall

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel


 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.