Re: [Xen-devel] [Patch] docs: Honour --{en, dis}able-xend when building docs

[Ian Campbell <Ian.Campbell@xxxxxxxxxx>]

On Mon, 2014-01-06 at 15:04 +0000, Ian Campbell wrote:
> On Mon, 2013-12-23 at 18:47 +0000, Andrew Cooper wrote:
> > If a user has specified --disable-xend, they wont want the manpages either.
> > 
> > Propagating this parameters requires reorganising the way in which the
> > makefile chooses which documents to build.
> > 
> > There is now a split of {MAN1,MAN5,MARKDOWN,TXT}SRC-y to select which
> > documentation to build, which is separate from the patsubst section which
> > generates appropriate paths to trigger the later rules.
> > 
> > The manpages are quite easy to split between xend, xl and xenstore, and have
> > been.  Items from misc/ are much harder and been left.
> > 
> > Signed-off-by: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
> 
> Acked-by: Ian Campbell <Ian.Campbell@xxxxxxxxxx>
> 
> > CC: Ian Jackson <Ian.Jackson@xxxxxxxxxxxxx>
> > CC: George Dunlap <george.dunlap@xxxxxxxxxxxxx>
> > 
> > --

NB only "---" (three dashes) has the affect you were intending here.
Possibly "-- " (two dashes and a space) does too but there was no space
in the above (and I don't know if that syntax works in the context of
git am...)
 
> > The configure scripts should be regenerated as part of applying this patch.
> > 
> > George:
> >    I request this gets a release ack for 4.4.  It could be argued as a bug 
> > in
> >    the current implementation of --disable-xend, and the extent of potential
> >    problems are that I have accidentally missed some of the manpages during
> >    the reorg, but this can be easily confirmed by comparing the results of 
> > the
> >    two builds (which I have done).
> 
> (as acting RM In George's absence):
> 
> I suppose I agree:
> Release-Acked-by: Ian Campbell <Ian.Campbell@xxxxxxxxxx>

With this applied I get the following difference to the set of installed
files. Given this and the fact that too many manpages being installed is
not the worst thing in the world I'm now inclined to say this should
wait for 4.5, since it's obviously not as trivial as it might seem.


--- ../FILE_LIST.BASE   2014-01-07 13:38:03.000000000 +0000
+++ ../FILE_LIST        2014-01-07 13:45:55.000000000 +0000
@@ -988,33 +988,25 @@
 dist/install/usr/local/share/doc/xen/html/man/xmdomain.cfg.5.html
 dist/install/usr/local/share/doc/xen/html/misc
 dist/install/usr/local/share/doc/xen/html/misc/console.txt
-dist/install/usr/local/share/doc/xen/html/misc/coverage.html
 dist/install/usr/local/share/doc/xen/html/misc/crashdb.txt
 dist/install/usr/local/share/doc/xen/html/misc/distro_mapping.txt
 dist/install/usr/local/share/doc/xen/html/misc/dump-core-format.txt
-dist/install/usr/local/share/doc/xen/html/misc/efi.html
 dist/install/usr/local/share/doc/xen/html/misc/grant-tables.txt
-dist/install/usr/local/share/doc/xen/html/misc/hvm-emulated-unplug.html
 dist/install/usr/local/share/doc/xen/html/misc/index.html
 dist/install/usr/local/share/doc/xen/html/misc/kexec_and_kdump.txt
 dist/install/usr/local/share/doc/xen/html/misc/libxl_memory.txt
 dist/install/usr/local/share/doc/xen/html/misc/pci-device-reservations.txt
 dist/install/usr/local/share/doc/xen/html/misc/printk-formats.txt
 dist/install/usr/local/share/doc/xen/html/misc/pvh-readme.txt
-dist/install/usr/local/share/doc/xen/html/misc/qemu-upstream_howto_use_it.html
 dist/install/usr/local/share/doc/xen/html/misc/sedf_scheduler_mini-HOWTO.txt
 dist/install/usr/local/share/doc/xen/html/misc/tscmode.txt
 dist/install/usr/local/share/doc/xen/html/misc/vbd-interface.txt
 dist/install/usr/local/share/doc/xen/html/misc/vtd.txt
 dist/install/usr/local/share/doc/xen/html/misc/vtpm.txt
-dist/install/usr/local/share/doc/xen/html/misc/xen-command-line.html
 dist/install/usr/local/share/doc/xen/html/misc/xen-error-handling.txt
 dist/install/usr/local/share/doc/xen/html/misc/xenpaging.txt
-dist/install/usr/local/share/doc/xen/html/misc/xenstore-paths.html
 dist/install/usr/local/share/doc/xen/html/misc/xenstore.txt
 dist/install/usr/local/share/doc/xen/html/misc/xl-disk-configuration.txt
-dist/install/usr/local/share/doc/xen/html/misc/xl-network-configuration.html
-dist/install/usr/local/share/doc/xen/html/misc/xl-numa-placement.html
 dist/install/usr/local/share/doc/xen/html/misc/xsm-flask.txt
 dist/install/usr/local/share/doc/xen/README.stubdom
 dist/install/usr/local/share/doc/xen/README.xenmon




_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel