Re: [Xen-devel] [PATCH V4] xl: create VFB for PV guest when VNC is specified

[Ian Campbell <Ian.Campbell@xxxxxxxxxx>]

On Mon, 2014-01-06 at 17:56 +0000, Wei Liu wrote:
> On Mon, Jan 06, 2014 at 05:29:01PM +0000, Ian Jackson wrote:
> > Ian Campbell writes ("Re: [PATCH V4] xl: create VFB for PV guest when VNC 
> > is specified"):
> > > And now George has gone away and left me holding the can, smart move on
> > > his part ;-)
> > 
> > I have also reviewed this patch again.
> > 
> > Firstly,
> > 
> > Acked-by: Ian Jackson <ian.jackson@xxxxxxxxxxxxx>
> > 
> > Now, onto the RM questions.
> > 
> > > The potential risk is that this breaks the existing vfb syntax which
> > > works, or it breaks the hvm stuff. This is of particular concern because
> > > I don't think any of that is covered by osstest (except perhaps hvm
> > > console, but that might only be on some other error when osstest takes a
> > > screenshot), so the probability of finding it before release is reliant
> > > on manual testing/test days/user testing etc.
> > > Are you happy that all the existing options keep working?
> > 
> > Wei, could you tell us what configuration(s) you tested ?
> > 
> 
[.snip.]

That looks pretty comprehensive.

Given that George has this in his list of open items for 4.4 with
"blocker?" (his query marker) I'm inclined towards giving a release
exception here.

Release-acked-by: Ian Campbell 

Ian.


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel