Re: [Xen-devel] [BUGFIX][PATCH 4/4] XEN_DOMCTL_gdbsx_guestmemio: always do the copyback.

[Mukesh Rathor <mukesh.rathor@xxxxxxxxxx>]

On Tue, 07 Jan 2014 11:26:36 -0500
Don Slutz <dslutz@xxxxxxxxxxx> wrote:

> On 01/07/14 05:00, Ian Campbell wrote:
> > On Mon, 2014-01-06 at 17:53 -0800, Mukesh Rathor wrote:
> >> On Sat,  4 Jan 2014 12:52:16 -0500
> >> Don Slutz <dslutz@xxxxxxxxxxx> wrote:
.....
> +++ b/tools/debugger/gdbsx/xg/xg_main.c
> @@ -787,8 +787,11 @@ xg_read_mem(uint64_t guestva, char *tobuf, int
> tobuf_len, uint64_t pgd3val) iop->gwr = 0;       /* not writing to
> guest */
> 
>       if ( (rc = _domctl_hcall(XEN_DOMCTL_gdbsx_guestmemio, tobuf,
> tobuf_len)) )
> -        XGTRC("ERROR: failed to read %d bytes. errno:%d rc:%d\n",
> -              iop->remain, errno, rc);
> +    {
> +        XGTRC("ERROR: failed to read bytes. errno:%d rc:%d\n",
> +              errno, rc);


Probably would fit in just one line. 
           XGTRC("ERROR: failed to read bytes. errno:%d rc:%d\n", errno, rc);


> +        return tobuf_len;
> +    }
> 
>       for(i=0; i < XGMIN(8, tobuf_len); u.buf8[i]=tobuf[i], i++);
>       XGTRC("X:remain:%d buf8:0x%llx\n", iop->remain, u.llbuf8);
> @@ -818,8 +821,11 @@ xg_write_mem(uint64_t guestva, char *frombuf,
> int buflen, uint64_t pgd3val) iop->gwr = 1;       /* writing to guest
> */
> 
>       if ((rc=_domctl_hcall(XEN_DOMCTL_gdbsx_guestmemio, frombuf,
> buflen)))
> -        XGERR("ERROR: failed to write %d bytes. errno:%d rc:%d\n",
> -              iop->remain, errno, rc);
> +    {
> +        XGERR("ERROR: failed to write bytes to %llx. errno:%d
> rc:%d\n",
> +              guestva, errno, rc);
> +        return buflen;
> +    }
>       return iop->remain;
>   }
> 
> 
> works fine and I plan it to be part of v2.

Yes, this is it.

thanks
Mukesh



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel