Re: [Xen-devel] [PATCH net-next 1/3] net: add skb_checksum_setup

[Paul Durrant <Paul.Durrant@xxxxxxxxxx>]

> -----Original Message-----
> From: Eric Dumazet [mailto:eric.dumazet@xxxxxxxxx]
> Sent: 08 January 2014 22:43
> To: Paul Durrant
> Cc: netdev@xxxxxxxxxxxxxxx; xen-devel@xxxxxxxxxxxxx; David Miller; Eric
> Dumazet; Veaceslav Falico; Alexander Duyck; Nicolas Dichtel
> Subject: Re: [PATCH net-next 1/3] net: add skb_checksum_setup
> 
> On Wed, 2014-01-08 at 13:58 +0000, Paul Durrant wrote:
> > This patch adds a function to set up the partial checksum offset for IP
> > packets (and optionally re-calculate the pseudo-header checksum) into the
> > core network code.
> > The implementation was previously private and duplicated between xen-
> netback
> > and xen-netfront, however it is not xen-specific and is potentially useful
> > to any network driver.
> >
> > Signed-off-by: Paul Durrant <paul.durrant@xxxxxxxxxx>
> > Cc: David Miller <davem@xxxxxxxxxxxxx>
> > Cc: Eric Dumazet <edumazet@xxxxxxxxxx>
> > Cc: Veaceslav Falico <vfalico@xxxxxxxxxx>
> > Cc: Alexander Duyck <alexander.h.duyck@xxxxxxxxx>
> > Cc: Nicolas Dichtel <nicolas.dichtel@xxxxxxxxx>
> > ---
> >  include/linux/netdevice.h |    1 +
> >  net/core/dev.c            |  271
> +++++++++++++++++++++++++++++++++++++++++++++
> >  2 files changed, 272 insertions(+)
> 
> Is there any reason to put this in net/core/dev.c instead of
> net/core/skbuff.c ?
> 

No, no reason. I just wasn't sure which was the better place. I'll put it in 
skbuff.c if that is more appropriate.

> 
> Also, no inline should be used in a .c file
> 
> ( skb_maybe_pull_tail )
> 

Ok. I'll fix that.

Thanks,

  Paul
_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel