Re: [Xen-devel] Backport request

[David Vrabel <david.vrabel@xxxxxxxxxx>]

On 13/01/14 11:13, Jan Beulich wrote:
>>>> On 13.01.14 at 10:49, Andrew Cooper <andrew.cooper3@xxxxxxxxxx> wrote:
>> Can you please backport c/s 0896bd8bea84526b00e00d2d076f4f953a3d73cb
>> "x86: map portion of kexec crash area that is within the direct map
>> area" to staging-4.3 ASAP, as following the backport of
>> 8d611a00d3389d9c16506326e24145b94ac6fb86 "kexec/x86: do not map crash
>> kernel area", kexec loading is broken in exactly the same way as it was
>> in staging.
> 
> Not without explaining how it is broken: According to my own
> checking as well as Daniel's there was no need for the kexec area
> to be mapped at all in the old implementation.
> 
> Furthermore, I'd prefer to revert 8d611a00 (dff90d0c on 4.2)
> instead if there really is an issue. That's largely because, as
> noted in the extra comment I added to 0896bd8b, the change is
> still incomplete (and hence not much better than the code with
> Daniel's change reverted).

In that comment it says:

  "That's primarily because map_domain_page()
   (needed when the area is outside the direct mapping range) may be
   unusable when wanting to kexec due to a crash,"

But map_domain_page() is only used when loading the crash image, not
during exec.

David

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel