Re: [Xen-devel] [PATCH v3 10/16] x86/VPMU: Initialize PMU for PV guests

["Jan Beulich" <JBeulich@xxxxxxxx>]

>>> On 06.01.14 at 20:24, Boris Ostrovsky <boris.ostrovsky@xxxxxxxxxx> wrote:
> --- a/xen/arch/x86/hvm/svm/vpmu.c
> +++ b/xen/arch/x86/hvm/svm/vpmu.c
> @@ -373,16 +373,21 @@ static int amd_vpmu_initialise(struct vcpu *v)
>        }
>      }
>  
> -    ctxt = xzalloc_bytes(sizeof(struct amd_vpmu_context) + 
> -                      sizeof(uint64_t) * AMD_MAX_COUNTERS + 
> -                      sizeof(uint64_t) * AMD_MAX_COUNTERS);
> -    if ( !ctxt )
> +    if ( is_hvm_domain(v->domain) )

Here and elsewhere - did you consider whether is_hvm_domain() is
still the correct thing here now that PVH code is in?

Jan


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel