Re: [Xen-devel] [PATCH v3 01/16] common/symbols: Export hypervisor symbols to PV guest

["Jan Beulich" <JBeulich@xxxxxxxx>]

>>> On 13.01.14 at 16:00, Boris Ostrovsky <boris.ostrovsky@xxxxxxxxxx> wrote:
> On 01/10/2014 12:01 PM, Jan Beulich wrote:
>>
>>> --- a/xen/arch/x86/x86_64/platform_hypercall.c
>>> +++ b/xen/arch/x86/x86_64/platform_hypercall.c
>>> @@ -32,6 +32,8 @@ CHECK_pf_pcpu_version;
>>>   CHECK_pf_enter_acpi_sleep;
>>>   #undef xen_pf_enter_acpi_sleep
>>>   
>>> +#define xenpf_symdata   compat_pf_symdata
>>> +
>> This should be done like other cases (see context above): Add a
>> CHECK_ invocation, which in turn requires an entry in include/xlat.lst.
> 
> Based on your comment to my attempt to patch compat.h, is this really 
> needed? Since xenpf_symdata contains a handle we shouldn't subject it to 
> checking, should we?

Correct. You nevertheless should add the new type to include/xlat.lst.

Jan


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel