Re: [Xen-devel] [PATCH] tools/xl: correctly shows split eventchannel for netfront

[Ian Campbell <Ian.Campbell@xxxxxxxxxx>]

On Wed, 2014-01-15 at 02:33 +0800, Annie Li wrote:
> From: Annie Li <annie.li@xxxxxxxxxx>
> 
> After split eventchannel feature was supported by netback/netfront,
> "xl network-list" does not show eventchannel correctly. Add tx-/rx-evt-ch
> to show tx/rx eventchannel correctly.
> 
> Signed-off-by: Annie Li <annie.li@xxxxxxxxxx>

How critical is this for 4.4?

Please consider
http://wiki.xen.org/wiki/Xen_Roadmap/4.4#Exception_guidelines_for_after_the_code_freeze
 and make a case for it if you think it should go in.

> diff --git a/tools/libxl/libxl_types.idl b/tools/libxl/libxl_types.idl
> index 649ce50..e6368c7 100644
> --- a/tools/libxl/libxl_types.idl
> +++ b/tools/libxl/libxl_types.idl
> @@ -488,7 +488,8 @@ libxl_nicinfo = Struct("nicinfo", [
>      ("frontend_id", uint32),
>      ("devid", libxl_devid),
>      ("state", integer),
> -    ("evtch", integer),
> +    ("evtch_tx", integer),
> +    ("evtch_rx", integer),

This needs backwards compatibility handling, see the big comment at the
head of libxl.h and the other examples in that file. I'm doubtful that
you will be able to remove the evtch field without breaking the API, so
it probably needs to stay even if it is explicitly invalid under some
circumstances.

It also needs a suitable LIBXL_HAVE_ #define, again see libxl.h.

Ian.


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel