Re: [Xen-devel] [PATCH net-next v4 1/9] xen-netback: Introduce TX grant map definitions

[Wei Liu <wei.liu2@xxxxxxxxxx>]

There is a stray blank line change in xenvif_tx_create_gop. (I removed
that part too early and didn't bother to paste it back...)

On Tue, Jan 14, 2014 at 08:39:47PM +0000, Zoltan Kiss wrote:
[...]
> +void xenvif_idx_unmap(struct xenvif *vif, u16 pending_idx)
> +{
> +     int ret;
> +     struct gnttab_unmap_grant_ref tx_unmap_op;
> +
> +     if (vif->grant_tx_handle[pending_idx] == NETBACK_INVALID_HANDLE) {
> +             netdev_err(vif->dev,
> +                        "Trying to unmap invalid handle! pending_idx: %x\n",
> +                        pending_idx);
> +             return;
> +     }
> +     gnttab_set_unmap_op(&tx_unmap_op,
> +                         idx_to_kaddr(vif, pending_idx),
> +                         GNTMAP_host_map,
> +                         vif->grant_tx_handle[pending_idx]);
> +     ret = gnttab_unmap_refs(&tx_unmap_op,
> +                             &vif->mmap_pages[pending_idx],
> +                             1);
> +
> +     ret = HYPERVISOR_grant_table_op(GNTTABOP_unmap_grant_ref,
> +                                     &tx_unmap_op,
> +                                     1);

As you said in your other email, this should be removed. :-)

> +     BUG_ON(ret);
> +     vif->grant_tx_handle[pending_idx] = NETBACK_INVALID_HANDLE;
> +}
>  
>  static void make_tx_response(struct xenvif *vif,
>                            struct xen_netif_tx_request *txp,
> @@ -1738,6 +1879,14 @@ static inline int tx_work_todo(struct xenvif *vif)
>       return 0;
>  }
>  
> +static inline bool tx_dealloc_work_todo(struct xenvif *vif)
> +{
> +     if (vif->dealloc_cons != vif->dealloc_prod)
> +             return true;
> +
> +     return false;

This can be simplified as
  return vif->dealloc_cons != vif->dealloc_prod;

Wei.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel