Re: [Xen-devel] [PATCH][v3] Pass the location of the ACPI RSDP to DOM0.

["Jan Beulich" <JBeulich@xxxxxxxx>]

>>> On 21.01.14 at 21:55, Philip Wernersbach <philip.wernersbach@xxxxxxxxx> 
>>> wrote:
> --- a/xen/arch/x86/setup.c
> +++ b/xen/arch/x86/setup.c
> @@ -1378,6 +1378,25 @@ void __init __start_xen(unsigned long mbi_p)
>              safe_strcat(dom0_cmdline, " acpi=");
>              safe_strcat(dom0_cmdline, acpi_param);
>          }
> +        if ( !strstr(dom0_cmdline, "acpi_rsdp=") )

Apart from all other reservations I have, you absolutely must not
do this unconditionally: This should be probably be limited to when
booting from EFI, and this should definitely be done only when
enabled by a command line option.

Jan

> +        {
> +            acpi_physical_address rp = acpi_os_get_root_pointer();
> +            char rp_str[sizeof(acpi_physical_address)*2 + 1];
> +
> +            if ( rp )
> +            {
> +                snprintf(rp_str, sizeof(acpi_physical_address)*2 + 1,
> +                         "%08lX", rp);
> +
> +                safe_strcat(dom0_cmdline, " acpi_rsdp=0x");
> +                safe_strcat(dom0_cmdline, rp_str);
> +            }
> +            else
> +            {
> +                printk(XENLOG_WARNING
> +                       "Failed to get acpi_rsdp to pass to dom0\n");
> +            }
> +        }
> 
>          cmdline = dom0_cmdline;
>      }




_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel