Re: [Xen-devel] [PATCH 1/3] pvusb drivers

["Luis R. Rodriguez" <mcgrof@xxxxxxxxxxxxxxxx>]

On Tue, Jan 21, 2014 at 8:53 AM, Alexander Savchenko
<oleksandr.savchenko@xxxxxxxxxxxxxxx> wrote:
> From: Nathanael Rensen <nathanael@xxxxxxxxxxxxxxxx>
>
> Signed-off-by: Alexander Savchenko <oleksandr.savchenko@xxxxxxxxxxxxxxx>

Without looking at the code yet I see you, the sender, are not on the
From address of the patch, but yet you Signed-off-by the patch. This
is good but not sufficient. If Nathanael tossed over a patch to you
and you want to credit them with authorship you certainly do want to
keep the From as from them but you should also be sure to have
received a Signed-off-by from them as well so you can add it above
your own Signed-off-by tag.

  Luis

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel