Re: [Xen-devel] [PATCH] mini-os: Fix stubdom build failures on gcc 4.8

[Ian Campbell <Ian.Campbell@xxxxxxxxxx>]

On Wed, 2014-01-22 at 18:19 +0100, Samuel Thibault wrote:
> xenmail43267@xxxxxxxxx, le Wed 22 Jan 2014 11:12:49 -0600, a Ãcrit :
> > index 16a4b49..ce5180c 100644
> > --- a/extras/mini-os/pcifront.c
> > +++ b/extras/mini-os/pcifront.c
> > @@ -424,7 +424,7 @@ int pcifront_physical_to_virtual (struct pcifront_dev 
> > *dev,
> >                  continue;
> >              }
> >  
> > -            if (sscanf(s, "%x:%x:%x.%x", dom, bus, slot, fun) != 4) {
> > +            if (sscanf(s, "%x:%x:%x.%lx", dom, bus, slot, fun) != 4) {
> >                  printk("\"%s\" does not look like a PCI device address\n", 
> > s);
> >                  free(s);
> >                  continue;
> 
> Rather make fun an unsigned int, there is no reason why it should be an
> unsigned long, I'm still wondering where that comes from.

This whole file has an interesting mix of unsigned long vs unsigned int
fun (it seems pretty consistent about dom, bus & slot). The use of
unsigned long seem to leak into the external interface to this file as
well.

For 4.4 this change is probably more appropriate at this juncture,
rather than shaving the yakk.

> 
> There rest seems OK to me.



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel