Re: [Xen-devel] [PATCH v4 03/17] x86/VPMU: Minor VPMU cleanup

["Jan Beulich" <JBeulich@xxxxxxxx>]

>>> On 21.01.14 at 20:08, Boris Ostrovsky <boris.ostrovsky@xxxxxxxxxx> wrote:
> --- a/xen/arch/x86/hvm/svm/vpmu.c
> +++ b/xen/arch/x86/hvm/svm/vpmu.c
> @@ -236,7 +236,8 @@ static int amd_vpmu_save(struct vcpu *v)
>  
>      context_save(v);
>  
> -    if ( !vpmu_is_set(vpmu, VPMU_RUNNING) && ctx->msr_bitmap_set )
> +    if ( !is_pv_domain(v->domain) && 

If I understand the intentions right, this is supposed to be
is_hvm_container_domain(). See the mail archives or talk to George D
if you want to learn about the intended distinction between the two.

Further this is inconsistent with the patch description saying "Make
sure that we only touch MSR bitmap on HVM guests", as that would
exclude PVH ones. With the three models in place now, you have to
be careful to not cause confusion by imprecise statements.

Jan


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel